Differences
This shows you the differences between two versions of the page.
| Both sides previous revision Previous revision | Last revision Both sides next revision | ||
|
admin [2015/04/22 15:09] mcb30 |
admin [2015/04/24 12:06] mcb30 |
||
|---|---|---|---|
| Line 32: | Line 32: | ||
| * All commits must include a ''Signed-off-by:'' line | * All commits must include a ''Signed-off-by:'' line | ||
| * Credit should be given to all participants in the work leading to the patch, including bug reporters (''Reported-by:''), testers (''Tested-by:''), original authors of a completely reimplemented patch (''Originally-implemented-by:'') etc. Since many contributions come via IRC, the (private) [[:nickmap]] page can be used to look up full names and e-mail addresses suitable for inclusion in the commit log. | * Credit should be given to all participants in the work leading to the patch, including bug reporters (''Reported-by:''), testers (''Tested-by:''), original authors of a completely reimplemented patch (''Originally-implemented-by:'') etc. Since many contributions come via IRC, the (private) [[:nickmap]] page can be used to look up full names and e-mail addresses suitable for inclusion in the commit log. | ||
| - | * Patches which fix a regression should refer to the commit which introduced the regression. | + | * Patches which have been modified from the code as originally submitted should include a ''Modified-by:'' line at the stage at which the modification took place. |
| + | * Patches which fix a regression should refer to the commit which introduced the regression, using both the commit ID and the header line. For example: ''Commit 8ab4b00 ("[libc] Rewrite setjmp() and longjmp()")'' | ||
